Will this help me improve my singing breathing? Singer's Help Needed?

My singing teacher makes me breath in for 8 seconds hold for 2 and let out slowly for about 6 seconds. We usually do it every time we sing and it helps a lot. Lung capacity I think comes mostly from practice. To help me breathe from my diaphragm she makes us sing "ha" up and down octaves. If you put your hand on your stomach you'll notice your stomach breathing. Hope this helps!